Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SFA iOS] Adds aggregate example #665

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[SFA iOS] Adds aggregate example #665

wants to merge 5 commits into from

Conversation

AyushBherwani1998
Copy link
Member

@AyushBherwani1998 AyushBherwani1998 commented Oct 1, 2024 •
edited
Loading

Motivation and Context

Jira Link: https://toruslabs.atlassian.net/browse/DEVREL-1009?atlOrigin=eyJpIjoiMDVjZDI2YWMxZWQ4NDY4MDg2ZDA2MzkwMjgwNTFhNmYiLCJwIjoiaiJ9

Description

Adds a new iOS SFA Aggregate Example

How has this been tested?

This has been tested locally

Screenshots (if appropriate):

simulator_screenshot_74617629-AEDE-4470-97B2-088575D7547C

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@vercel Vercel
Copy link

vercel bot commented Oct 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mpc-core-kit-aggregate-verifier-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 6:53am
mpc-core-kit-angular-quick-start ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 6:53am
mpc-core-kit-farcaster ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 6:53am
mpc-core-kit-nextjs-quick-start ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 6:53am
mpc-core-kit-react-quick-start ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 6:53am
mpc-core-kit-solana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 6:53am
mpc-core-kit-vue-quick-start ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 6:53am
sfa-angular-quick-start 🛑 Canceled (Inspect) Oct 17, 2024 6:53am
sfa-nextjs-quick-start ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 6:53am
sfa-react-quick-start ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 6:53am
sfa-react-vite-quick-start ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 6:53am
sfa-vanillajs-quick-start ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 6:53am
sfa-vue-quick-start ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 6:53am
sfa-web-aggregate-verifier-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 6:53am
sfa-web-auth0-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 6:53am
sfa-web-bitcoin-example 🛑 Canceled (Inspect) Oct 17, 2024 6:53am
sfa-web-farcaster ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 6:53am
sfa-web-google-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 6:53am
sfa-web-nextauth-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 6:53am
sfa-web-passwordless-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 6:53am
sfa-web-ton-telegram-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 6:53am
sfa-web-ton-telegram-server 🛑 Canceled (Inspect) Oct 17, 2024 6:53am
web3auth-core-kit-examples 🛑 Canceled (Inspect) Oct 17, 2024 6:53am
web3auth-core-kit-examples-za3d ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 6:53am

ihsraham
ihsraham reviewed Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@ihsraham ihsraham left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
I don't see an option to logout.
I tried to search the methods provided by the Web3Auth SDK and I didn't see logout being offered. Is logout not present in SFA Swift SDK? @AyushBherwani1998

ihsraham
ihsraham reviewed Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@ihsraham ihsraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both the login options, Google and Email Passwordless make me log in through Google via Auth0.

@AyushBherwani1998
Copy link
Member Author

We don't have a logout function or a way to clear the session manager as of now in the SFA mobile SDKs. I have solved the issue of only google being used for both the options.

ihsraham
ihsraham approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@ihsraham ihsraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vercel Vercel
Copy link

vercel bot commented Oct 17, 2024

Deployment failed with the following error:

Too many requests - try again in 3 minutes (more than 120, code: "api-deployments-flood-pro").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihsraham ihsraham ihsraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AyushBherwani1998 @ihsraham